Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix horizontal overflow for SampleCode component #501

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

ericyliu
Copy link
Contributor

@ericyliu ericyliu commented Jan 16, 2024

fixes issue #687

  • not the most elegant fix, but prevents the horizontal overflow. We could consider making the code in the box smaller incrementally with less horizontal screen space to prevent line wrapping, but that's not a perfect solution either
  • also removes some extra padding at the bottom of SampleCode

Screenshot 2024-01-16 at 2 43 21 PM

@ericyliu ericyliu self-assigned this Jan 16, 2024
Copy link
Contributor

@alexdavid alexdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a horizontal scrollbar to long codeblocks instead of wrapping? I think I've seen that more often than wrapping, but I don't feel strongly

@ericyliu
Copy link
Contributor Author

that's a good point, it'll look nicer for the parts that are visible, let me change that

@ericyliu ericyliu merged commit 88d873c into redesign Jan 18, 2024
32 checks passed
@ericyliu ericyliu deleted the 687-fix-doc-horizontal-scrolling branch January 18, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants