Optionally use code from S3 rather than zip - Fixes #65 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for an optional 'code' block inside the 'lambda' config that specifies the s3 bucket/key/version to use when creating or updating the lambda function. If the 'code' block is provided, no zip file is created.
This was referenced Jun 12, 2016
| key: path/to/hello.jar | ||
| # version is optional and refers to the object's version ID | ||
| # see: http://docs.aws.amazon.com/AmazonS3/latest/dev/ObjectVersioning.html | ||
| version: 123 |
There was a problem hiding this comment.
What happens when this is omitted? What happens when we migrate from non-code from s3 to code from s3?
|
Needs tests :) |
|
bump |
|
Closing as the OP never responded :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for an optional 'code' block inside the 'lambda'
config that specifies the s3 bucket/key/version to use when creating or
updating the lambda function.
If the 'code' block is provided, no zip file is created.
I also added a section to the README that explains how to use this.