Allow run::bind config to specify different destination #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaWatt
reviewed
Jul 24, 2024
pyrex.py
Outdated
| class ParsingError(Exception): | ||
| def __init__(self, message): | ||
| super().__init__(message) | ||
| self.message = message |
There was a problem hiding this comment.
This is unnecessary. The message passed to Exception is the default when the exception is printed as a string:
try:
raise Exception("Hello")
except Exception as e:
print("%s" % e)Hello
There was a problem hiding this comment.
I'd probably just do:
class ParsingError(Exception):
passThere was a problem hiding this comment.
Oh, bad luck on my part. I tested all of this using KeyError as my dummy exception type to carry along the string. I didn't like that it artificially enclosed the string inside single-quotes. Turns out that behavior is specific to KeyError. You're right that str(Exception('Hello')) does act the way I'd want.
Thanks. I'll update it.
matthoosier-garmin
force-pushed
the
specify-bind-mount-destination
branch
2 times, most recently
from
6178ff5
to
2c35e46
Compare
JoshuaWatt
approved these changes
Jul 24, 2024
Until now, the directories mentioned in this config key have always been
mounted at the same absolute path in the container as they exist on the
host. Extend this to allow a different destination path in the container:
...
[run]
bind =
...
/src-path:/dst-path
...
All of the usual options already recognized are valid for entries
specified using this expanded syntax.
Change-Id: Iaa0e70325f576d71ea672da082ce1a76c9c81c94
matthoosier-garmin
force-pushed
the
specify-bind-mount-destination
branch
from
2c35e46
to
1d593cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the directories mentioned in this config key have always been mounted at the same absolute path in the container as they exist on the host. Extend this to allow a different destination path in the container:
...
[run]
bind =
...
/src-path:/dst-path
...
All of the usual options already recognized are valid for entries specified using this expanded syntax.
Change-Id: Iaa0e70325f576d71ea672da082ce1a76c9c81c94