This repository has been archived by the owner on Oct 31, 2020. It is now read-only.
compiled footer scss file #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Best reviewed: commit by commit
Optimal code review plan
|
|
@garimasingh128 could you once review the PR and let me know if any changes are required. Should all these deploy checks pass? I am not sure about it. |
|
Yup, I will review it after 1st. As of now, it looks okay |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compiled footer.scss file to generate footer.css, earlier it was not compiled properly, CSS was thus invalid and hence footer did not have background color.
Fixes #1
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Deployed the site to netlify to confirm the working.
The fixed version can is deployed here
Checklist: