Skip to content
This repository has been archived by the owner on Oct 31, 2020. It is now read-only.

Background and Alignment of footer section #1

Open
madhhuurrii opened this issue Sep 24, 2020 · 11 comments · May be fixed by #6
Open

Background and Alignment of footer section #1

madhhuurrii opened this issue Sep 24, 2020 · 11 comments · May be fixed by #6
Assignees
Labels
bug Something isn't working enhancement New feature or request Hacktoberfest

Comments

@madhhuurrii
Copy link

madhhuurrii commented Sep 24, 2020

Describe the bug
Background is not present in footer section and unalignment of footer content i.e it is in extreme left.

To Reproduce
Steps to reproduce the behavior:

  1. Go to live website
  2. Scroll down to footer section
  3. See error

Expected behavior
Background should be according to description in readme file i.e dark blue.
Alignment of content should be at center

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot_20200925-050416_Samsung Internet

Desktop (please complete the following information):

  • OS: Windows
  • Browser : Google Chrome
  • Version : 10

Smartphone (please complete the following information):

  • Device: Samsung Galaxy M30s
  • OS: Android 10.0 (Q) with One UI 2.0
  • Browser : Samsung Internet
  • Version : Android 10

Additional context
Add any other context about the problem here.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.77. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Sep 24, 2020
@garimasingh128 garimasingh128 added enhancement New feature or request Hacktoberfest labels Sep 25, 2020
@SinghCoder SinghCoder linked a pull request Sep 25, 2020 that will close this issue
5 tasks
@SoldierCorp
Copy link

Hi,

I would like to help, can you assign it to me please?

@garimasingh128
Copy link
Owner

Already PR #6 is created for it. You may create more issues or simply add your fav movie to data.json file.

@madhhuurrii
Copy link
Author

Hii @garimasingh128 , actually wanted to know is the PR made before oct 1 are counted for hacktoberfest cos i was willing to work on this issue but was actually waiting for the dates

@garimasingh128
Copy link
Owner

Hacktoberfest 2020 has begun as seen on the website. Go and register there asap. I think the PR would be counted but you can wait until 1st if you want.

@devcshort
Copy link

@garimasingh128 @madhhuurrii this is incorrect. Hacktoberfest has not started yet and any PRs created before October 1st will not count.

In their FAQs it states

all pull requests created between Oct 1 and Oct 31 will count, regardless of when you register for Hacktoberfest. Pull requests created before Oct 1 but merged or marked as ready for review after do not count.

You can see here under the Rules section

@garimasingh128
Copy link
Owner

My apologies for the same. @madhhuurrii you may close your PR and open another one after 1st Oct.

@SoldierCorp
Copy link

Hi @garimasingh128,

People are looking for unassigned issues and this issue was already covered by @madhhuurrii but it hasn't been assigned yet and is still appearing in the search results so you should assign it to @madhhuurrii please

@garimasingh128
Copy link
Owner

It would be fine right if I assign multiple people to the same issue?

@madhhuurrii
Copy link
Author

Hii @garimasingh128 , I have solved the issue , please review it

@madhhuurrii
Copy link
Author

Hii @garimasingh128 would like to know if this repository's contribution count towards hacktoberfest 2020.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants