Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .gitkeep files in lib directory #91

Closed
wants to merge 1 commit into from
Closed

Remove .gitkeep files in lib directory #91

wants to merge 1 commit into from

Conversation

big-samantha
Copy link

The benefit of prepopulating the lib directories is outweighed by
the annoyance of accidentally pluginsyncing needless .gitkeep files to
all your nodes unless you remember to remove them.

pluginsync is already sufficiently opinionated about where things go.

The benefit of prepopulating the lib directories is outweighed by
the annoyance of accidentally pluginsyncing needless `.gitkeep` files to
all your nodes unless you remember to remove them.

`pluginsync` is already sufficiently opinionated about where things go.
@garethr
Copy link
Owner

garethr commented Nov 13, 2015

Mmm, this will clober the lib folder which no-longer has anything in it though. I'd probably rather note this and add some starting point files for writing your own types and providers I think.

@big-samantha
Copy link
Author

Mmm, this will clober the lib folder which no-longer has anything in it though. I'd probably rather note this and add some starting point files for writing your own types and providers I think.

I realize that, but so what? It's basically just the "remember to delete this entire directory" directory for 90% of the modules people are going to generate.

@walkamongus
Copy link

FWIW I think I agree with @pizzaops -- if someone wants to start building their own types and providers, I would hope they would know (or can easily figure out) they have to create the lib directories.

@rauchrob
Copy link
Contributor

There is another approach, though: strip the .gitkeep files in install.sh (see my PR #92). That way the generated modules will have an empty lib directory etc.

@garethr
Copy link
Owner

garethr commented Nov 17, 2015

Thanks for the discussion. I've merged #92 as an alternative solution to this issue. Cheers.

@garethr garethr closed this Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants