Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document backport branches and auto update #81

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Vincinator
Copy link
Contributor

@Vincinator Vincinator commented Feb 13, 2025

What this PR does / why we need it:

  • Documents the purpose of maint-X.Y branches
  • Documents auto update to latest patch level

Related #47

@Vincinator Vincinator force-pushed the doc/backports-and-auto-updates branch from 7aed23a to b66763b Compare February 13, 2025 12:28
@Vincinator Vincinator force-pushed the doc/backports-and-auto-updates branch from 99ed0b8 to aadd6e4 Compare February 13, 2025 12:36
@Vincinator Vincinator marked this pull request as ready for review February 13, 2025 12:36
Copy link
Member

@fwilhe fwilhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many comments, mostly nitpicks, thanks for taking care @Vincinator

Any kernel version that we need to maintain other than the latest LTS in main, are maintained in `maint-<MAJOR.MINOR>` branches (e.g. maint-6.6).
Actual backport releases need to branch of from the respective `maint-<MAJOR.MINOR>` branch and include the corresponding `.container` file for target backport.

Branches containing the `.container` file must be named according to the `rel-MAJOR` naming scheme (e.g. rel-1443).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we should explain what the .container file does here. I think this is not the right place, but it might be confusing to people who are unaware of our package build. Not sure if we have proper docs we can link here.

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh - Misinterpreted you comment. Fully agree, we need to document .container somewhere - have not found it either.

Sorry, running low on coffee .



> [!Note]
> We must create rel- branches to include the respective `.container` file, and not use maint for backports. This is required because multiple releases can use the same kernel version (e.g. rel-1443 and rel-1592 both use maint-6.6)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you think this diagram could be helpful here? not sure if that makes it more clear, what I'm trying to show here is how the branches relate.. left our 'main' branches that always build with the latest env, and right is nightly (no special branch) and our releases (rel branches with .container file)

flowchart LR
    A[main branch] --> B(Garden Linux nightly)
    A[main branch] --> F(Garden Linux 18xx, TBD)
    C[maint-6.6 branch] --> D(rel-1443 branch, Garden Linux 1443)
    C[maint-6.6 branch] --> E(rel-1592 branch, Garden Linux 1592)
Loading

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can make it more generic

Branch Description Release Builds Example
main branch Builds kernel version for Garden Linux today's MAJOR.0 via nightly Garden Linux nightly -
maint-X.Y branch Keeps sources for Linux X.Y on latest patch level - maint-6.6
rel-MAJOR branches Based on maint-X.Y, used for backport builds of Linux X.Y for Garden Linux MAJOR Backport builds of Linux X.Y for Garden Linux MAJOR - rel-1443 uses maint-6.6
- rel-1592 uses maint-6.6
- rel-18XX uses maint-6.12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I think this table is helpful

Vincinator and others added 4 commits February 13, 2025 14:18
Co-authored-by: Florian Wilhelm <[email protected]>
Co-authored-by: Florian Wilhelm <[email protected]>
Co-authored-by: Florian Wilhelm <[email protected]>
Co-authored-by: Florian Wilhelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants