VM Instance Initialization: Driver.InitializeMachine #898
+260
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
the
size/m
elankath
added
do-not-merge/work-in-progress
and removed
size/m
gardener-robot-ci-1
added
reviewed/ok-to-test
unmarshall
reviewed
Feb 14, 2024
unmarshall
reviewed
Feb 14, 2024
gardener-robot
added
the
size/m
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
rishabh-11
requested changes
Mar 8, 2024
| @@ -407,6 +410,7 @@ func (c *controller) triggerCreationFlow(ctx context.Context, createMachineReque | |||
| klog.Errorf("Error while creating machine %s: %s", machine.Name, err.Error()) | |||
| return c.machineCreateErrorHandler(ctx, machine, createMachineResponse, err) | |||
| } | |||
| newlyCreatedMachine = true | |||
There was a problem hiding this comment.
Yes. I would suggest to move newlyCreatedMachine = true to the end of the block.
| @@ -407,6 +410,7 @@ func (c *controller) triggerCreationFlow(ctx context.Context, createMachineReque | |||
| klog.Errorf("Error while creating machine %s: %s", machine.Name, err.Error()) | |||
| return c.machineCreateErrorHandler(ctx, machine, createMachineResponse, err) | |||
| } | |||
| newlyCreatedMachine = true | |||
There was a problem hiding this comment.
We should remove the newlyCreatedMachine variable and just use uninitializedMachine. Set uninitializedMachine to true after the VM creation is successful.
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot
added
size/l
gardener-robot-ci-3
added
reviewed/ok-to-test
rishabh-11
requested changes
Mar 26, 2024
gardener-robot
added
size/m
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
kon-angelo
reviewed
Apr 3, 2024
| @@ -267,6 +325,7 @@ If the conditions defined below are encountered, the provider MUST return the sp | |||
| | 13 INTERNAL | Major error | Means some invariants expected by underlying system has been broken. If you see one of these errors, something is very broken. | Needs manual intervension to fix this | N | | |||
| | 14 UNAVAILABLE | Not Available | Unavailable indicates the service is currently unavailable. | Retry operation after sometime | Y | | |||
| | 16 UNAUTHENTICATED | Missing provider credentials | Request does not have valid authentication credentials for the operation | Fix the provider credentials | N | | |||
| | 17 UNINITIALIZED | Failed Initialization| VM Instance could not be initializaed | Initialization is reattempted in next reconcile cycle | N | | |||
There was a problem hiding this comment.
initializaed
initialized
kon-angelo
reviewed
Apr 3, 2024
Comment on lines
+199
to
+200
| | 13 INTERNAL | Major error | Means some invariants expected by underlying system has been broken. | Needs investigation and possible intervention to fix this | Y | | ||
| | 17 UNINITIALIZED | Failed Initialization| VM Instance could not be initializaed | Initialization is reattempted in next reconcile cycle | Y | |
There was a problem hiding this comment.
| 13 INTERNAL | Major error | Means some invariants expected by underlying system has been broken. | Needs investigation and possible intervention to fix this | Y |
In practice not many will make a distinction between uninitialized and internal - why would they since both errors are retryable. If there is a difference in the requeue time maybe but. Saying Needs investigation and possible intervention to fix this and still allowing retries does not make sense. I think we could live without the "uninitialized" error per the spec.
There was a problem hiding this comment.
Hi Konstantinos, We need the Uninitialized error code to disambiguate the specific case of an un-initialized machine. The Internal error code is more like a generic error code in the MCM presently.
Maybe you are right and we can remove codes.Internal from the response error codes for InitializeMachine to be more strict and not lenient.
There was a problem hiding this comment.
But how should I, as a extension maintainer differentiate ? What is an example use-case ? Maybe it can be added in the description
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
See #871
Enhance the Machine Controller
triggerCreationFlowto correctly handle post-creation instance initialization steps with appropriate retry handling.Which issue(s) this PR fixes:
Fixes part of #871
Special notes for your reviewer:
Release note: