Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #773: Fix machine creation bootstrap tokens expiration #777

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Automated cherry pick of #773: Fix machine creation bootstrap tokens expiration #777

merged 1 commit into from
Feb 1, 2023

Conversation

himanshu-kun
Copy link
Contributor

@himanshu-kun himanshu-kun commented Feb 1, 2023 •
edited
Loading

What this PR does / why we need it:

The expiration of bootstrap tokens is hardcoded in the machine controller deployment. (depending on the provider but mostly approx. 20min).
There is an option to overwrite this default per worker group with machineCreationTimeout.
This option is considered during the machine creation but not in the bootstrap token.
So this means that if the machine takes more time than 20 minutes to be created, the bootstrap token is already expired and the needed configs cannot be fetched form the cluster.

This PR makes the bootstrap token respect the machines machineCreationTimeout option.

Which issue(s) this PR fixes:
Fixes #772

Special notes for your reviewer:

Tested with the equinix provider

Release note:

Fix a bug in the bootstrap token creation that caused node to not be able to join the cluster due to an expired bootstrap token.

@himanshu-kun himanshu-kun requested a review from a team as a code owner February 1, 2023 11:01
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 1, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 1, 2023
rishabh-11
rishabh-11 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 1, 2023
@himanshu-kun himanshu-kun merged commit 6342f6a into gardener:rel-v0.48 Feb 1, 2023
@himanshu-kun himanshu-kun deleted the automated-cherry-pick-of-#773-upstream-rel-v0.48 branch February 1, 2023 14:21
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@himanshu-kun @rishabh-11 @gardener-robot-ci-3 @gardener-robot @schrodit