Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Progressing condition on machineDeployment for nil progressDeadlineSeconds #762

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Update Progressing condition on machineDeployment for nil progressDeadlineSeconds #762

merged 1 commit into from
Dec 15, 2022

Conversation

himanshu-kun
Copy link
Contributor

What this PR does / why we need it:
Currently when progressDeadlineSeconds is nil , then no Progressing condition is added to machineDeployment. This PR adds that condition now.
In gardener, currently we deploy machineDeployments with this field as nil , but we would also like to see if the deployment is rollingUpdating or not. Now that this condition would be present, we could achieve that.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

MachineDeployment would now have `Progressing` condition even when no progress Deadline is specified. This condition would never go to the reason `ProgressDeadlineExceeded` in that case.

@himanshu-kun himanshu-kun requested a review from a team as a code owner December 13, 2022 10:46
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Dec 13, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 13, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2022
kon-angelo
kon-angelo approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 15, 2022
@himanshu-kun himanshu-kun merged commit 251dcd1 into gardener:master Dec 15, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 15, 2022
@himanshu-kun himanshu-kun deleted the update-progressing-condition-on-md branch December 15, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees

@kon-angelo kon-angelo

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@himanshu-kun @kon-angelo @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot