Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update short names for Machine, MachineClass, MachineDeployment and MachineSet resources #749

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Update short names for Machine, MachineClass, MachineDeployment and MachineSet resources #749

merged 1 commit into from
Oct 13, 2022

Conversation

rishabh-11
Copy link
Contributor

@rishabh-11 rishabh-11 commented Oct 11, 2022 •
edited
Loading

What this PR does / why we need it:
This PR updates the short names for Machine, MachineClass, MachineDeployment and MachineSet resources. The new and final ones are as follows:

  1. mc - machine
  2. mcc - machineClass
  3. mcd - machineDeployment
  4. mcs - machineSet

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Added new short names for machine(mc), machineClass(mcc), machineDeployment(mcd), and machineSet(mcs) resources.

@rishabh-11 rishabh-11 requested a review from a team as a code owner October 11, 2022 14:43
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 11, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 11, 2022
This was referenced Oct 12, 2022
Merged
Merged
himanshu-kun
himanshu-kun approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 13, 2022
@himanshu-kun himanshu-kun merged commit 01111a6 into gardener:master Oct 13, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 13, 2022
@rishabh-11 rishabh-11 deleted the update-short-names branch October 14, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishabh-11 @himanshu-kun @gardener-robot-ci-1 @gardener-robot