Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing node field from machine status #745

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Removing node field from machine status #745

merged 3 commits into from
Jan 9, 2023

Conversation

rishabh-11
Copy link
Contributor

@rishabh-11 rishabh-11 commented Sep 19, 2022 •
edited by himanshu-kun
Loading

What this PR does / why we need it:
This PR removes the node field in the machine status and replaces its usage with the node label present in the machine object's metadata.

Which issue(s) this PR fixes:
Fixes #389

Special notes for your reviewer:
ITs were run for aws and azure providers with the seed as the control cluster.

Release note:

`node` field is removed from machine status. controller will now depend on the node label which already was present in the machine object's metadata. If you(or your controller) are dependent on the `status.node` field of the machine object, then kindly use `node` label under `.metadata.labels`

@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else labels Sep 19, 2022
@gardener-robot
Copy link

@rishabh-11 Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels Sep 19, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 19, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2022
@rishabh-11 rishabh-11 force-pushed the remove-node-from-machine-status branch from 5dae24b to 345b365 Compare September 19, 2022 12:06
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 19, 2022
@rishabh-11 rishabh-11 marked this pull request as ready for review September 19, 2022 12:19
@rishabh-11 rishabh-11 requested a review from a team as a code owner September 19, 2022 12:19
himanshu-kun
himanshu-kun suggested changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Sorry the ultra-delay in reviewing this PR.
I have asked for a few changes.

pkg/controller/machine.go Outdated Show resolved Hide resolved
pkg/controller/machine.go Outdated Show resolved Hide resolved
pkg/controller/machine.go Outdated Show resolved Hide resolved
pkg/util/provider/machinecontroller/machine.go Outdated Show resolved Hide resolved
pkg/util/provider/machinecontroller/machine.go Outdated Show resolved Hide resolved
pkg/util/provider/machinecontroller/machine_test.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jan 5, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 5, 2023
himanshu-kun
himanshu-kun approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 9, 2023
@himanshu-kun himanshu-kun merged commit 4fba966 into gardener:master Jan 9, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 9, 2023
@himanshu-kun himanshu-kun mentioned this pull request Feb 23, 2023
Merged
rfranzke added a commit to rfranzke/gardener that referenced this pull request Mar 6, 2023
@rfranzke
Adapt code to removed .status.node field
8c9a5af 
See gardener/machine-controller-manager#745
rfranzke added a commit to rfranzke/gardener that referenced this pull request Mar 6, 2023
@rfranzke
Adapt code to removed .status.node field
8c3036b 
See gardener/machine-controller-manager#745
gardener-prow bot pushed a commit to gardener/gardener that referenced this pull request Mar 10, 2023
@rfranzke
Revendor github.com/gardener/[email protected] (#7599
3088536 
)

* Revendor `github.com/gardener/[email protected]`

* Adapt code to removed `.status.node` field

See gardener/machine-controller-manager#745

* Delete deprecated provider-specific `MachineClass` CRDs

* Maintain CRDs

* Revert "Delete deprecated provider-specific `MachineClass` CRDs"

This reverts commit f56ca6f.

The in-tree providers are only removed with [email protected]+.

* Revert "Maintain CRDs"

This reverts commit 468e562.

* Address PR review feedback
@himanshu-kun himanshu-kun mentioned this pull request Apr 11, 2023
Closed
@rishabh-11 rishabh-11 deleted the remove-node-from-machine-status branch April 12, 2023 10:29
andrerun pushed a commit to andrerun/gardener that referenced this pull request Jul 6, 2023
@rfranzke @andrerun
Revendor github.com/gardener/[email protected] (ga…
be60fe2 
…rdener#7599)

* Revendor `github.com/gardener/[email protected]`

* Adapt code to removed `.status.node` field

See gardener/machine-controller-manager#745

* Delete deprecated provider-specific `MachineClass` CRDs

* Maintain CRDs

* Revert "Delete deprecated provider-specific `MachineClass` CRDs"

This reverts commit f56ca6f.

The in-tree providers are only removed with [email protected]+.

* Revert "Maintain CRDs"

This reverts commit 468e562.

* Address PR review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall left review comments

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees
No one assigned
Labels
kind/api-change API change with impact on API users needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove MCM's dependency on Status.Node while adoption
7 participants
@rishabh-11 @gardener-robot @unmarshall @himanshu-kun @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3