Support URL encoded bootstrap token replacement #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gerrit91 Thank you for your contribution. |
|
@Gerrit91 You need rebase this pull request with latest master branch. Please check. |
gardener-robot
added
needs/rebase
|
Thank you @Gerrit91 for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
Gerrit91
force-pushed
the
support-ignition
branch
from
3b0d661
to
84592bf
Compare
himanshu-kun
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot
added
reviewed/lgtm
|
/invite @unmarshall |
|
@unmarshall You have pull request review open invite, please check |
himanshu-kun
suggested changes
Sep 5, 2022
|
@Gerrit91 we are planning to make a release by EoD |
Gerrit91
force-pushed
the
support-ignition
branch
from
84592bf
to
8786751
Compare
|
Hey @himanshu-kun. Thanks for review. I integrated your change request into the PR and rebased onto master. |
himanshu-kun
suggested changes
Sep 6, 2022
Gerrit91
force-pushed
the
support-ignition
branch
from
8786751
to
45b113f
Compare
gardener-robot
removed
needs/review
himanshu-kun
added
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
himanshu-kun
changed the title
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In metal-stack we do not use the wide-spread software cloud-init for preparing cloud instances but Ignition. The Ignition userdata format encodes data with URL scheme, such that special characters are not contained in user-given contents of the userdata.
The current code patches a placeholder
<<BOOTSTRAP_TOKEN>>in order to enrich the userdata with a node's bootstrap token. As the placeholder contains special characters, the string replacement does not work for Ignition-formatted userdata, which looks like:This PR allows detecting the URL-encoded placeholder as well and properly replaces the bootstrap token into the userdata.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: