Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Multi-Arch Images 📦 #732

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Jul 7, 2022

What this PR does / why we need it:
This PR lets the CI pipeline build multi-arch images with support for linux/amd64 and linux/arm64.

/kind enhancement
/area delivery

Which issue(s) this PR fixes:
Fixes parts of gardener/gardener#6258

Special notes for your reviewer:
The build steps have been unified along the way, i.e. make build builds the MCM binary locally for the system the build is executed on and make docker-image builds the MCM binary within the docker image. There is no dedicated local linux/amd64 build anymore as I didn't see any benefit of keeping it. Please let me know if you think otherwise.

Release note:

Published docker images for Machine-Controller-Manager are now multi-arch ready. They support `linux/amd64` and `linux/arm64`.

@timuthy timuthy requested a review from a team as a code owner July 7, 2022 08:17
@gardener-robot gardener-robot added area/delivery Delivery related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jul 7, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 7, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 7, 2022
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR
You would be raising similar PRs for the mcm-providers also right?
and would similar change be required in cluster autoscaler as i see the make build is capable of creating mulit-arch images (pls correct me if I am wrong) , but in the pipeline we create the binary like this which I think would not create multi-arch binary

.ci/pipeline_definitions Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jul 7, 2022
@timuthy
Copy link
Member Author

timuthy commented Jul 7, 2022

You would be raising similar PRs for the mcm-providers also right?

The primary goal of gardener/gardener#6258 is to have ARM support for the local dev environment. We can file PRs for MCM providers after supporting the local use case as testing this will involve more effort.

and would similar change be required in cluster autoscaler

Yes, I can file a PR for that.

@himanshu-kun
Copy link
Contributor

You would be raising similar PRs for the mcm-providers also right?

The primary goal of gardener/gardener#6258 is to have ARM support for the local dev environment. We can file PRs for MCM providers after supporting the local use case as testing this will involve more effort.

and would similar change be required in cluster autoscaler

Yes, I can file a PR for that.

Thanks that would be great!

Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Jul 7, 2022
@himanshu-kun himanshu-kun merged commit a3e8792 into gardener:master Jul 11, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 11, 2022
@timuthy timuthy deleted the feature.arm64-support branch July 11, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/delivery Delivery related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants