Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce ResourceExhausted error code for openstack #97

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Re-introduce ResourceExhausted error code for openstack #97

merged 3 commits into from
Sep 26, 2023

Conversation

rishabh-11
Copy link
Contributor

@rishabh-11 rishabh-11 commented Sep 19, 2023 •
edited
Loading

What this PR does / why we need it:
As a part of gardener/autoscaler#154, ResourceExhausted error code will be returned when no valid host is found in the zone to host the VM.

Sample live issue - No. 958

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
After discussions with @kon-angelo and @himanshu-kun, we have concluded that quotas are set per region and so there is no point in introducing early backoff for such errors.

Release note:

`ResourceExhausted` error code is returned when no valid host is found in the zone

@rishabh-11 rishabh-11 requested review from a team as code owners September 19, 2023 11:43
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 19, 2023
@rishabh-11
Copy link
Contributor Author

cc @himanshu-kun

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 19, 2023
@himanshu-kun himanshu-kun changed the title Introduce ResourceExhausted error code Re-introduce ResourceExhausted error code for openstack Sep 19, 2023
himanshu-kun
himanshu-kun previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 19, 2023
@himanshu-kun
Copy link
Contributor

/invite @kon-angelo

@gardener-robot gardener-robot added needs/review Needs review and removed reviewed/lgtm Has approval for merging labels Sep 19, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 19, 2023
kon-angelo
kon-angelo requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you certain that 403 is only used for quota issues ? The way it is expressed in this PR indicates so, but I am not so sure. Lacking the proper rbac would probably result in the same error. Did you verify it via an experiment ?

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Sep 22, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 22, 2023
himanshu-kun
himanshu-kun previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Sep 22, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 22, 2023
@gardener-robot gardener-robot added needs/changes Needs (more) changes needs/review Needs review and removed needs/review Needs review reviewed/lgtm Has approval for merging labels Sep 26, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 26, 2023
kon-angelo
kon-angelo approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes labels Sep 26, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 26, 2023
himanshu-kun
himanshu-kun approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit a281613 into gardener:master Sep 26, 2023
6 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 26, 2023
@rishabh-11 rishabh-11 deleted the error-codes branch September 27, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rishabh-11 @himanshu-kun @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot