Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework orphan deletion #65

Merged
merged 3 commits into from
Jul 11, 2022
Merged

rework orphan deletion #65

merged 3 commits into from
Jul 11, 2022

Conversation

kon-angelo
Copy link
Contributor

What this PR does / why we need it:

Similar to gardener/machine-controller-manager-provider-aws#85

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

probeResources() now doesn't try to delete orphan resources but only lists them.
The beforeSuite for IT test now calls for cleanup of orphan resources separately.
The Integration Test, which looks for orphan resources, now doesn't try to delete the orphan resources and just waits for them to be done automatically.

@kon-angelo kon-angelo requested review from a team as code owners July 4, 2022 19:30
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jul 4, 2022
@kon-angelo
Copy link
Contributor Author

/invite @himanshu-kun

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2022
@gardener-robot
Copy link

@himanshu-kun You have pull request review open invite, please check

himanshu-kun
himanshu-kun suggested changes Jul 11, 2022
View reviewed changes
test/integration/provider/openstack.go Outdated Show resolved Hide resolved
test/integration/provider/rti.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jul 11, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 11, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 11, 2022
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jul 11, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 11, 2022
himanshu-kun
himanshu-kun approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@himanshu-kun himanshu-kun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Jul 11, 2022
@kon-angelo kon-angelo merged commit 14d8be4 into gardener:master Jul 11, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 11, 2022
@kon-angelo kon-angelo deleted the enh/rework-orphan branch July 11, 2022 11:07
@kon-angelo
Copy link
Contributor Author

/fixes #58

@gardener-robot
Copy link

@kon-angelo Command /fixes is not known.

@kon-angelo kon-angelo mentioned this pull request Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshu-kun himanshu-kun himanshu-kun approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kon-angelo @gardener-robot @himanshu-kun @gardener-robot-ci-2 @gardener-robot-ci-3