Set DeleteOnTermination for in BlockDeviceMappings to false in case of volumes with RootDiskType #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In case of a
RootDiskType
is specified the volume will be created before creating the server. Also while deletion the server gets deleted first and than also the volume is getting deleted.In the
BlockDeviceMapping
currently we setDeleteOnTermination: true
this is wrong because the volume gets deleted by the mcm.Special notes for your reviewer:
Release note: