add support for multiple facilities, metros and reservation IDs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <[email protected]>
|
@deitch Thank you for your contribution. |
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
rfranzke
reviewed
Aug 25, 2021
Signed-off-by: Avi Deitcher <[email protected]>
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Signed-off-by: Avi Deitcher <[email protected]>
gardener-robot-ci-2
added
the
reviewed/ok-to-test
rfranzke
requested changes
Aug 25, 2021
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
Looks like commenting is back (sort of).
I didn't understand it that way. Doesn't each worker pool in the |
|
OK, I missed that the EQXM can take multiple facilities when a device is created (contrary/different compared to how it's done for hyperscalers). In that case, forget about the previous review, it should be all good as is. |
|
I cannot get in to see the CI build error. Can you see what it is, so I can fix it? After that, I will test against live EQXM, and then we can merge in. |
Signed-off-by: Avi Deitcher <[email protected]>
|
OK, migration removed. Let's see if this passes. |
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
CI is clean! |
rfranzke
approved these changes
Aug 25, 2021
|
/hold until final tests were conducted |
gardener-robot
added
the
reviewed/do-not-merge
gardener-robot-ci-1
added
the
reviewed/ok-to-test
|
I had to change the manifests and add a debug log line. Already tested:
Will be testing with reservations later today, then this can go in. |
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
rfranzke
approved these changes
Aug 25, 2021
deitch
force-pushed
the
metros-and-facilities
branch
from
cc39b34
to
c0441da
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
Signed-off-by: Avi Deitcher <[email protected]>
deitch
force-pushed
the
metros-and-facilities
branch
from
c0441da
to
83f4fe2
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Signed-off-by: Avi Deitcher <[email protected]>
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avi Deitcher [email protected]
What this PR does / why we need it:
Adds support for:
Special notes for your reviewer:
This has not been properly tested yet. I need @rfranzke to review and make sure it aligns with gardener-extension-provider-packet 154, and then I can test it.
@rfranzke please take make sure I captured your target resource API correctly.
Release note: