Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to equinix sdk and remove facility usage #23

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Switch to equinix sdk and remove facility usage #23

merged 1 commit into from
Mar 3, 2024

Conversation

schrodit
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #16

Special notes for your reviewer:

Also switched to the newer equinix sdk as the old packet is dprecated.

Release note:

Equinix Metal is deprecating facility deployment. Metros encompass multiple facilities and are a better fit for availability concerns.
The machine controller manager is now only doing metro deployments.
Current facility deployed machines are handled as before and will be replaced with the next os or K8s update.

@schrodit schrodit self-assigned this Feb 17, 2024
@schrodit schrodit requested review from jonas-zipprick and a team as code owners February 17, 2024 21:20
@gardener-robot gardener-robot added the needs/review Needs review label Feb 17, 2024
@schrodit
Copy link
Collaborator Author

/ok-to-test

@gardener-robot
Copy link
Contributor

@schrodit Thank you for your contribution.

@gardener-robot-ci-2
Copy link
Contributor

Thank you @schrodit for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 17, 2024
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 17, 2024
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 18, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 18, 2024
@gardener-robot
Copy link
Contributor

@jonas-zipprick You have pull request review open invite, please check

@schrodit schrodit merged commit bb97421 into gardener:main Mar 3, 2024
7 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 3, 2024
@schrodit schrodit deleted the facility-dep branch March 3, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-zipprick jonas-zipprick Awaiting requested review from jonas-zipprick jonas-zipprick is a code owner

Assignees

@schrodit schrodit

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facility Deprecation
4 participants
@schrodit @gardener-robot @gardener-robot-ci-2 @gardener-robot-ci-3