Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mcm to 0.49.1 #14

Merged
merged 3 commits into from
May 25, 2023
Merged

Upgrade mcm to 0.49.1 #14

merged 3 commits into from
May 25, 2023

Conversation

himanshu-kun
Copy link
Contributor

@himanshu-kun himanshu-kun commented May 18, 2023 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

upgraded dependency:

github.com/gardener/machine-controller-manager -> v0.49.1

@himanshu-kun himanshu-kun requested review from a team as code owners May 18, 2023 10:16
@gardener-robot gardener-robot added the needs/review Needs review label May 18, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 18, 2023
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 18, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 18, 2023
schrodit
schrodit requested changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take a look at the failed test and build

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label May 19, 2023
@himanshu-kun
Copy link
Contributor Author

please take a look at the failed test and build

the pipeline are running on go1.17.9 that why, I have created PR to upgrade pipelines #15 , will update this PR once #15 is merged.

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 23, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 23, 2023
@rishabh-11 rishabh-11 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2023
@rishabh-11 rishabh-11 changed the title Upgrade mcm to 0.49.0 Upgrade mcm to 0.49.1 May 25, 2023
@rishabh-11 rishabh-11 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 25, 2023
rishabh-11
rishabh-11 approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label May 25, 2023
@gardener-robot gardener-robot removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels May 25, 2023
@rishabh-11 rishabh-11 merged commit 54babab into gardener:main May 25, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 25, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schrodit schrodit schrodit requested changes

@rishabh-11 rishabh-11 rishabh-11 approved these changes

Assignees

@schrodit schrodit

@rishabh-11 rishabh-11

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@himanshu-kun @schrodit @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot