Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go version to 1.22.5 #159

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Update go version to 1.22.5 #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .ci/pipeline_definitions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ machine-controller-manager-provider-azure:
steps_template: &steps_anchor
steps:
check:
image: 'golang:1.21.4'
image: 'golang:1.22.5'
build:
image: 'golang:1.21.4'
image: 'golang:1.22.5'
output_dir: 'binary'
test:
image: 'europe-docker.pkg.dev/gardener-project/releases/testmachinery/base-step:stable'
Expand Down Expand Up @@ -61,7 +61,7 @@ machine-controller-manager-provider-azure:
interval: '24h'
update_component_deps:
set_dependency_version_script_container_image:
image_reference: 'golang:1.21.4'
image_reference: 'golang:1.22.5'
release:
<<: *steps_anchor
traits:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# SPDX-License-Identifier: Apache-2.0

############# builder #############
FROM golang:1.21.4 AS builder
FROM golang:1.22.5 AS builder

WORKDIR /go/src/github.com/gardener/machine-controller-manager-provider-azure
COPY . .
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/gardener/machine-controller-manager-provider-azure

go 1.21
go 1.22

require (
github.com/Azure/azure-sdk-for-go/sdk/azcore v1.9.0
Expand Down
1 change: 0 additions & 1 deletion pkg/azure/provider/helpers/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,6 @@ func createNICDeleteTask(resourceGroup, nicName string, nicAccess *armnetwork.In
func createDisksDeletionTasks(resourceGroup string, diskNames []string, diskAccess *armcompute.DisksClient) []utils.Task {
tasks := make([]utils.Task, 0, len(diskNames))
for _, diskName := range diskNames {
diskName := diskName // TODO: remove this once https://github.com/golang/go/wiki/LoopvarExperiment becomes part of 1.21.x
taskFn := func(ctx context.Context) error {
klog.Infof("Attempting to delete disk: [ResourceGroup: %s, DiskName: %s] if it exists", resourceGroup, diskName)
return accesshelpers.DeleteDisk(ctx, diskAccess, resourceGroup, diskName)
Expand Down