Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master]Upgrade http client library 'got' to latest version #757

Merged
merged 1 commit into from
Jul 30, 2020
Merged

[master]Upgrade http client library 'got' to latest version #757

merged 1 commit into from
Jul 30, 2020

Conversation

holgerkoser
Copy link
Member

@holgerkoser holgerkoser commented Jul 30, 2020 •
edited by petersutter
Loading

  • Improve reflector logging
    We have observed situations where the kube-apiserver is throttling requests from the dashboard. In the log we see that a request does not return and the reflector loop is blocked.
    log
    There are some closed iusses in got (e.g. 1341, 1295 and 1287) which describe problems with hanging requests. These issues could be the reason for cache expiration problems in the dashboard backend.

  • version

  • better req & res logging

  • upgrade got to latest version

  • some fixes

  • added unit tests

  • revert version change

  • PR feedback I

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@holgerkoser
[hotfix-1.43] Upgrade http client library 'got' to latest version (#756)
3a9c895 
* Improve reflector logging

* version

* better req & res logging

* upgrade got to latest version

* some fixes

* added unit tests

* revert version change

* PR feedback I
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 30, 2020
@petersutter petersutter changed the title Upgrade http client library 'got' to latest version [master]Upgrade http client library 'got' to latest version Jul 30, 2020
petersutter
petersutter approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jul 30, 2020
grolu
grolu approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@holgerkoser holgerkoser merged commit 6fe1927 into master Jul 30, 2020
@holgerkoser holgerkoser deleted the upgrade-got branch July 30, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@grolu grolu grolu approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@holgerkoser @petersutter @grolu @gardener-robot-ci-2 @gardener-robot