Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Provider Credentials #2195

Merged
merged 43 commits into from
Jan 23, 2025
Merged

Refactor Provider Credentials #2195

merged 43 commits into from
Jan 23, 2025

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Nov 21, 2024 •
edited
Loading

This PR refactors the backend /cloudprovidersecrets API

  • Removed old endpoint that returned custom dashboard secret resource
  • Added new /cloudprovidercredentials endpoint that returns list of credentials (sets) that contain related SecretBinding, Secret (if own) and resolved Quota resources
  • Renamed secret store to credential store

This PR is also a preparation to support new CredentialsBinding resource

  • Started renaming secret to credential (store)
  • Work with SecretBinding as the leading resource, access referenced secret only when we need to access the actual secret data
  • In a follow-up PR we can then also read CredentialsBindings in the backend and return with the list. The dashboard can then work with CredentialsBindings and SecretBindings in the frontend as they are more or less interchangeable. Only the reference to the Secret / WorkloadIdentity data is different so we need to add some kind of abstraction / transformation there.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Tests need to be adapted

Release note:

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2024
@grolu
Some fixes
8c08bd0 
Highlight secret row instead of open secret dialog
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2024
@grolu
use composable for shared secret data
b4c0e22 
show secret data in edit mode
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2024
holgerkoser
holgerkoser reviewed Nov 25, 2024
View reviewed changes
backend/lib/services/cloudProviderCredentials.js Outdated Show resolved Hide resolved
frontend/src/components/Secrets/GSecretDetailsItemContent.vue Outdated Show resolved Hide resolved
frontend/src/store/credential.js Outdated Show resolved Hide resolved
frontend/src/store/credential.js Outdated Show resolved Hide resolved
frontend/src/store/credential.js Outdated Show resolved Hide resolved
frontend/src/store/credential.js Outdated Show resolved Hide resolved
frontend/src/utils/index.js Outdated Show resolved Hide resolved
backend/lib/services/cloudProviderCredentials.js Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 26, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 27, 2024
@grolu grolu force-pushed the enh/refactor-secrets branch from dbef902 to 5b82bcd Compare November 27, 2024 11:24
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2025
petersutter
petersutter reviewed Jan 20, 2025
View reviewed changes
frontend/src/views/GSecrets.vue Outdated Show resolved Hide resolved
frontend/src/components/GShootSecretName.vue Outdated Show resolved Hide resolved
@grolu
PR Feedback
e4968fc 
- Removed secret item route
- Navigate to page with highlighted secret
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 21, 2025
@grolu
use useUrlSearchParams
3aec2d2 
fixed secret dialog resizing
reset highlighted secret on click
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 22, 2025
petersutter
petersutter reviewed Jan 22, 2025
View reviewed changes
frontend/src/components/Secrets/GSecretDialog.vue Outdated Show resolved Hide resolved
frontend/src/components/Secrets/GSecretRowDns.vue Outdated Show resolved Hide resolved
frontend/src/components/Secrets/GSecretRowInfra.vue Outdated Show resolved Hide resolved
frontend/src/views/GSecrets.vue Outdated Show resolved Hide resolved
frontend/src/views/GSecrets.vue Outdated Show resolved Hide resolved
frontend/src/views/GSecrets.vue Outdated Show resolved Hide resolved
frontend/src/views/GSecrets.vue Outdated Show resolved Hide resolved
frontend/src/views/GSecrets.vue Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2025
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jan 23, 2025
@gardener-robot
Copy link

@grolu You need rebase this pull request with latest master branch. Please check.

petersutter
petersutter approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 23, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 23, 2025
@grolu
Merge branch 'master' into enh/refactor-secrets
4cb107b 
# Conflicts:
#	frontend/__tests__/components/Vuetify.spec.js
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Jan 23, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 23, 2025
@grolu grolu merged commit 8402b90 into master Jan 23, 2025
10 checks passed
@grolu grolu deleted the enh/refactor-secrets branch January 23, 2025 11:31
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 23, 2025
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 23, 2025
@grolu grolu mentioned this pull request Jan 23, 2025
Open
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser left review comments

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@grolu @gardener-robot @holgerkoser @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3