Implemented virtual scrolling for Shoot List #1674

grolu · 2024-01-03T15:28:35Z

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1363

Special notes for your reviewer:

Release note:

Implemented virtual scrolling for the cluster list. Rows are now rendered dynamically as you scroll, replacing the previous paging option. This improvement optimizes performance and provides a smoother browsing experience when viewing large data sets

…o enh/virtual_table

# Conflicts: # frontend/src/views/GShootList.vue

grolu · 2024-07-24T14:03:57Z

Currently, we need to manually set item-height. This workaround could be an issue as we may have dynamic row heights if we wrap content.
See also: vuetifyjs/vuetify#18806

petersutter · 2024-10-09T12:55:53Z

there is a bug with the table when you scroll to the bottom and then filter the table using the search input field. As long as you do not scroll, only a subset of the result will be displayed

grolu · 2024-10-11T11:42:53Z

there is a bug with the table when you scroll to the bottom and then filter the table using the search input field. As long as you do not scroll, only a subset of the result will be displayed

This seems to be a bug in Vuetify: vuetifyjs/vuetify#20566 and vuetifyjs/vuetify#18926

- Added workaround for vuetify rendering issue when virtual table scroll position is not initial

gardener-robot · 2024-11-21T09:07:50Z

@grolu You need rebase this pull request with latest master branch. Please check.

grolu · 2025-01-20T16:44:19Z

This seems to be a bug in Vuetify: vuetifyjs/vuetify#20566 and vuetifyjs/vuetify#18926

The issue has been fixed in the upstream vuetify project so we can continue testing this PR

frontend/src/components/GDataTableFooter.vue

petersutter · 2025-01-21T09:33:01Z

frontend/src/views/GShootList.vue

        class="g-table"
+        height="calc(100vh - 240px)"
+        item-height="50px"


check if needed

yes. definitely needed. Added a test to check that behavior doesn't change.

frontend/src/views/GShootList.vue

petersutter · 2025-01-21T09:41:50Z

frontend/src/components/GDataTableFooter.vue

-        aria-label="Last page"
-        @click="setPage(pageCount)"
-      />
+    <template v-if="pageCount">


can we use the default footer?

No. The default footer is empty, but I think it makes sense to display the number of clusters

petersutter

Minor change request, otherwise /lgtm

frontend/__tests__/components/Vuetify.spec.js

# Conflicts: # frontend/__tests__/components/Vuetify.spec.js

Implemented virtual scrolling for Shoot List

503b390

gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Jan 3, 2024

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 3, 2024

gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 3, 2024

Merge branch 'master' into enh/virtual_table

65b34e9

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 5, 2024

Merge branch 'master' into enh/virtual_table

5cd2f7c

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 6, 2024

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 6, 2024

grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Mar 7, 2024

Merge branch 'master' into enh/virtual_table

c268f03

grolu changed the title ~~Implemented virtual scrolling for Shoot List~~ [DRAFT] Implemented virtual scrolling for Shoot List Mar 8, 2024

Merge branch 'master' into enh/virtual_table

7b730b7

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2024

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2024

grolu added 2 commits May 29, 2024 15:45

Merge branch 'enh/virtual_table' of github.com:gardener/dashboard int…

5ce880f

…o enh/virtual_table

Merge branch 'master' into enh/virtual_table

df30d37

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2024

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2024

grolu mentioned this pull request Jun 4, 2024

[IPCEI] UI Improvements #1903

Open

64 tasks

Merge branch 'master' into enh/virtual_table

417ce2f

# Conflicts: # frontend/src/views/GShootList.vue

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 18, 2024

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 18, 2024

Merge branch 'master' into enh/virtual_table

20f881d

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 23, 2024

Merge branch 'master' into enh/virtual_table

e63ae96

gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 9, 2024

Merge branch 'master' into enh/virtual_table

ae51a90

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 9, 2024

- Removed option to switch between virtual scrolling and paging

713f097

- Added workaround for vuetify rendering issue when virtual table scroll position is not initial

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 11, 2024

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 11, 2024

gardener-robot added the needs/rebase Needs git rebase label Nov 21, 2024

Merged master

e1ad223

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2025

Removed workaround for scroll position not initial issue

4476799

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2025

petersutter reviewed Jan 21, 2025

View reviewed changes

grolu added 2 commits January 22, 2025 17:22

PR Feedback

2d418d6

Merge branch 'master' into enh/virtual_table

767bfb8

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2025

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 22, 2025

petersutter approved these changes Jan 23, 2025

View reviewed changes

frontend/__tests__/components/Vuetify.spec.js Outdated Show resolved Hide resolved

Merge branch 'master' into enh/virtual_table

c08e11a

# Conflicts: # frontend/__tests__/components/Vuetify.spec.js

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 23, 2025

grolu merged commit 4bab298 into master Jan 23, 2025
10 checks passed

grolu deleted the enh/virtual_table branch January 23, 2025 12:16

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented virtual scrolling for Shoot List #1674

Implemented virtual scrolling for Shoot List #1674

grolu commented Jan 3, 2024 •

edited

Loading

grolu commented Jul 24, 2024

petersutter commented Oct 9, 2024

grolu commented Oct 11, 2024 •

edited

Loading

gardener-robot commented Nov 21, 2024

grolu commented Jan 20, 2025

petersutter Jan 21, 2025

grolu Jan 22, 2025

petersutter Jan 21, 2025

grolu Jan 22, 2025

petersutter left a comment

Implemented virtual scrolling for Shoot List #1674

Implemented virtual scrolling for Shoot List #1674

Conversation

grolu commented Jan 3, 2024 • edited Loading

grolu commented Jul 24, 2024

petersutter commented Oct 9, 2024

grolu commented Oct 11, 2024 • edited Loading

gardener-robot commented Nov 21, 2024

grolu commented Jan 20, 2025

petersutter Jan 21, 2025

Choose a reason for hiding this comment

grolu Jan 22, 2025

Choose a reason for hiding this comment

petersutter Jan 21, 2025

Choose a reason for hiding this comment

grolu Jan 22, 2025

Choose a reason for hiding this comment

petersutter left a comment

Choose a reason for hiding this comment

grolu commented Jan 3, 2024 •

edited

Loading

grolu commented Oct 11, 2024 •

edited

Loading