PR Feedback

gardener · Jan 22, 2025 · 0c20607 · 0c20607
1 parent 3aec2d2
commit 0c20607
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 27 deletions.
diff --git a/frontend/src/components/Secrets/GSecretDialog.vue b/frontend/src/components/Secrets/GSecretDialog.vue
@@ -26,7 +26,7 @@ SPDX-License-Identifier: Apache-2.0
         </template>
       </g-toolbar>
       <v-card-text>
-        <div class="d-flex flex-row pa-3 card-content">
+        <div class="d-flex flex-row pa-3">
           <div
             ref="secretDetails"
             class="d-flex flex-column flex-grow-1"
@@ -398,9 +398,4 @@ export default {
   pointer-events: none;
 }
 
-.card-content {
-    overflow: scroll;
-    height: auto;
-  }
-
 </style>
diff --git a/frontend/src/components/Secrets/GSecretRowDns.vue b/frontend/src/components/Secrets/GSecretRowDns.vue
@@ -141,7 +141,6 @@ export default {
   $highlighted-color: rgb(var(--v-theme-accent));
 
   .secret-row {
-    background-color: inherit;
     transition: background-color 0.5s ease;
 
     &.highlighted {

diff --git a/frontend/src/components/Secrets/GSecretRowInfra.vue b/frontend/src/components/Secrets/GSecretRowInfra.vue
@@ -138,7 +138,6 @@ export default {
   $highlighted-color: rgb(var(--v-theme-accent));
 
   .secret-row {
-    background-color: inherit;
     transition: background-color 0.5s ease;
 
     &.highlighted {

diff --git a/frontend/src/views/GSecrets.vue b/frontend/src/views/GSecrets.vue
@@ -261,6 +261,7 @@ import {
   mapActions,
 } from 'pinia'
 import { useUrlSearchParams } from '@vueuse/core'
+import { toRef } from 'vue'
 
 import { useCloudProfileStore } from '@/store/cloudProfile'
 import { useGardenerExtensionStore } from '@/store/gardenerExtension'
@@ -303,6 +304,13 @@ export default {
     GDataTableFooter,
   },
   inject: ['mergeProps'],
+  setup () {
+    const hashParams = useUrlSearchParams('hash-params')
+    const highlightedUid = toRef(hashParams, 'credential-uid')
+    return {
+      highlightedUid,
+    }
+  },
   data () {
     return {
       selectedSecretBinding: {},
@@ -318,7 +326,6 @@ export default {
         { value: 10, title: '10' },
         { value: 20, title: '20' },
       ],
-      hashParams: useUrlSearchParams('hash-params'),
     }
   },
   computed: {
@@ -467,29 +474,25 @@ export default {
         return this.computeItem(secretBinding, relatedShootCount)
       })
     },
-    highlightedUid: {
-      get () {
-        return this.hashParams['credential-uid']
-      },
-      set (highlightedUid) {
-        this.hashParams['credential-uid'] = highlightedUid
-      },
-    },
   },
   watch: {
     namespace () {
       this.reset()
     },
-  },
-  mounted () {
-    const infraIndex = findIndex(this.infrastructureSecretSortedItems, { secretBinding: { metadata: { uid: this.highlightedUid } } })
-    if (infraIndex !== -1) {
-      this.infraSecretPage = Math.floor(infraIndex / this.infraSecretItemsPerPage) + 1
-    }
-    const dnsIndex = findIndex(this.dnsSecretSortedItems, { secretBinding: { metadata: { uid: this.highlightedUid } } })
-    if (dnsIndex !== -1) {
-      this.dnsSecretPage = Math.floor(dnsIndex / this.dnsSecretItemsPerPage) + 1
-    }
+    highlightedUid: {
+      immediate: true,
+      handler (value) {
+        const infraIndex = findIndex(this.infrastructureSecretSortedItems, ['secretBinding.metadata.uid', value])
+        if (infraIndex !== -1) {
+          this.infraSecretPage = Math.floor(infraIndex / this.infraSecretItemsPerPage) + 1
+        }
+
+        const dnsIndex = findIndex(this.dnsSecretSortedItems, ['secretBinding.metadata.uid', value])
+        if (dnsIndex !== -1) {
+          this.dnsSecretPage = Math.floor(dnsIndex / this.dnsSecretItemsPerPage) + 1
+        }
+      },
+    },
   },
   methods: {
     ...mapActions(useCredentialStore, [