Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio and Gateway API gateway resources as source objects #174

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
The Istio resource Gateway can now be annotated with cert.gardener.cloud/purpose=managed to enable the automatic creation of Certificate resources for domain names extracted from hosts fields in this resource or related VirtualServices resources.
The Gateway and HTTPRoute resources from the Gateway API are supported in a similar way.
As the custom resource definitions for Istio or the Gateway API are optionally, these resources are only watched if they are available. As a side-effect, if these custom resources are added or removed, the cert-controller-manager container exits to restart and reconfigure its controller to the new situation.

Which issue(s) this PR fixes:
Fixes #29

Special notes for your reviewer:
Related to same feature for dns-controller-managaer, see to gardener/external-dns-management#354

Release note:

The Istio resource `Gateway` can now be annotated with `cert.gardener.cloud/purpose=managed` to enable the automatic creation of `Certificate` resources for domain names extracted from hosts fields in this resource or related `VirtualServices` resources.
The `Gateway` and `HTTPRoute` resources from the Gateway API are supported in a similar way.

@MartinWeindel MartinWeindel requested a review from a team as a code owner April 23, 2024 08:29
@gardener-robot gardener-robot added the needs/review Needs review label Apr 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2024
@gardener-robot gardener-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Apr 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 23, 2024
@MartinWeindel MartinWeindel merged commit 9d5d03f into master Apr 23, 2024
7 checks passed
@MartinWeindel MartinWeindel deleted the gateway-sources branch April 23, 2024 13:04
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 23, 2024
@MartinWeindel MartinWeindel added the area/ipcei IPCEI (Important Project of Common European Interest) label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make cert-management aware of Istio gateway resource
4 participants