Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message if DNS entry is not ready #151

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
Improve message if DNS entry is not ready. The status of DNSEntries are now checked if either they have no provider or the status message is added to the error.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Improve message if DNS entry is not getting ready.

@MartinWeindel MartinWeindel requested a review from a team as a code owner November 16, 2023 15:41
@gardener-robot gardener-robot added needs/review Needs review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 16, 2023
@MartinWeindel MartinWeindel merged commit c1702e1 into master Nov 16, 2023
7 checks passed
@MartinWeindel MartinWeindel deleted the enh/improve-dnsentry-not-ready branch November 16, 2023 16:07
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants