Skip to content
This repository was archived by the owner on Nov 9, 2022. It is now read-only.

Vendor dependencies #105

Merged
merged 5 commits into from
Jan 29, 2021
Merged

Vendor dependencies #105

merged 5 commits into from
Jan 29, 2021

Conversation

@timuthy
Copy link
Contributor

@timuthy timuthy commented Jan 29, 2021 •
edited by rfranzke
Loading

How to categorize this PR?

/area open-source
/kind enhancement
/priority normal

What this PR does / why we need it:
This PR updates the following dependencies.

github.com/gardener/gardener v1.16.0
sigs.k8s.io/controller-runtime v0.7.1
k8s.io/* v0.19.6

Special notes for your reviewer:
/cc @timebertt

Release note:

Go dependencies have been updated to:
github.com/gardener/gardener v1.16.0
sigs.k8s.io/controller-runtime v0.7.1
k8s.io/* v0.19.6

Gardener-Resource-Manager now needs permission to `get`, `create`, `update` and `watch` `Lease` objects named `gardener-resource-manager` in order to perform leader election. For a reference, please have a look at the pre-delivered Helm chart in `charts/gardener-resource-manager`.

@timuthy timuthy requested a review from a team as a code owner January 29, 2021 14:00
@gardener-robot gardener-robot added the needs/review Needs review label Jan 29, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 29, 2021
@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension priority/normal size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jan 29, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 29, 2021
@rfranzke
Copy link
Contributor

rfranzke commented Jan 29, 2021

make revendor needs to be ran again

@rfranzke
Copy link
Contributor

rfranzke commented Jan 29, 2021

/assign

rfranzke
rfranzke previously approved these changes Jan 29, 2021
View reviewed changes
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 29, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 29, 2021
timebertt
timebertt reviewed Jan 29, 2021
View reviewed changes
Copy link
Contributor

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thank you, @timuthy.
There is a lot of boilerplate code we are able to get rid of now :)
Only one nit, rest looks good.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 29, 2021
@timebertt
Copy link
Contributor

timebertt commented Jan 29, 2021

Can you add a release note that grm now needs access to leases? ref kubernetes-sigs/controller-runtime#1144

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 29, 2021
timebertt
timebertt reviewed Jan 29, 2021
View reviewed changes
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 29, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 29, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 29, 2021
@rfranzke rfranzke requested a review from timebertt January 29, 2021 16:35
@timuthy
Copy link
Contributor Author

timuthy commented Jan 29, 2021

/squash

@gardener-robot gardener-robot added the merge/squash Should be merged via 'Squash and merge' label Jan 29, 2021
@timuthy timuthy mentioned this pull request Jan 29, 2021
Merged
timebertt
timebertt approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Thanks for adapting the chart as well :)
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 29, 2021
@timebertt timebertt merged commit b69b352 into gardener-attic:master Jan 29, 2021
@timuthy timuthy deleted the vendor branch January 29, 2021 16:50
@rfranzke rfranzke mentioned this pull request Feb 17, 2021
Closed
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@rfranzke rfranzke rfranzke approved these changes

@timebertt timebertt timebertt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rfranzke rfranzke

Labels

area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@timuthy @rfranzke @timebertt @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot