Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns policy and config validation #79

Merged
merged 1 commit into from
Oct 9, 2020
Merged

dns policy and config validation #79

merged 1 commit into from
Oct 9, 2020

Conversation

mfranczy
Copy link
Contributor

@mfranczy mfranczy commented Oct 8, 2020

Signed-off-by: Marcin Franczyk [email protected]

How to categorize this PR?

/area robustness
/kind enhancement
/priority normal
/platform kubevirt

What this PR does / why we need it:
Adds validation for DNS

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

improvement_user

@mfranczy
dns policy and config validation
f8ef096 
Signed-off-by: Marcin Franczyk <[email protected]>
@mfranczy mfranczy requested a review from a team as a code owner October 8, 2020 13:07
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure priority/normal size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Oct 8, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 8, 2020
@mfranczy
Copy link
Contributor Author

mfranczy commented Oct 8, 2020

@stoyanr since I don't plan to provider runstrategy the validation is quite simple, we can talk about this tomorrow morning as we agreed.

@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 8, 2020
@stoyanr stoyanr merged commit 73a03be into gardener-attic:master Oct 9, 2020
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) needs/lgtm Needs approval for merging and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoyanr stoyanr stoyanr approved these changes

Assignees
No one assigned
Labels
area/robustness Robustness, reliability, resilience related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfranczy @stoyanr @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot