Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make pre-allocated data volumes configurable #60

Merged
merged 1 commit into from
Sep 28, 2020
Merged

make pre-allocated data volumes configurable #60

merged 1 commit into from
Sep 28, 2020

Conversation

moadqassem
Copy link
Contributor

@moadqassem moadqassem commented Sep 25, 2020 •
edited
Loading

How to categorize this PR?
/area high-availability
/area performance
/kind enhancement
/kind api-change
/priority normal
/platform kubevirt

What this PR does / why we need it:
Make the KubeVirt DataVolume pre-allocation configurable, in order to control the creation of the data volumes which going to be cloned.
Which issue(s) this PR fixes:
Fixes #56

Release note:

DataVolume pre-allocation configurability

@moadqassem moadqassem requested a review from a team as a code owner September 25, 2020 07:27
@gardener-robot gardener-robot added platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure priority/normal labels Sep 25, 2020
@gardener-robot
Copy link
Contributor

@moadqassem Labels area/todo, kind/todo do not exist.

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 25, 2020
@gardener-robot gardener-robot added area/high-availability High availability related area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension labels Sep 25, 2020
@moadqassem moadqassem force-pushed the make-pre-allocated-data-volumes-configurable branch from 49e19fc to a582fc3 Compare September 25, 2020 07:35
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 25, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 25, 2020
@moadqassem moadqassem force-pushed the make-pre-allocated-data-volumes-configurable branch from a582fc3 to ecc6eb7 Compare September 28, 2020 11:23
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 28, 2020
@stoyanr stoyanr merged commit b809ba0 into gardener-attic:master Sep 28, 2020
@stoyanr stoyanr mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoyanr stoyanr stoyanr approved these changes

Assignees
No one assigned
Labels
area/high-availability High availability related area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/kubevirt Container Native Virtualization (CNV) KubeVirt platform/infrastructure reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make pre-allocated data volumes configurable
6 participants
@moadqassem @gardener-robot @stoyanr @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3