feat(templates): allow templating in template path #6736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new template variable for `RenderTemplate` configs:
`${template.path}`. This is the absolute path to the config template
being rendered. This is useful when you want to use the full path to a
file or directory next to the `ConfigTemplate` that's being rendered
(e.g. to use a shared Dockerfile that belongs the template, every time
you render that template).
stefreak
reviewed
Dec 20, 2024
Comment on lines
+319
to
+320
| @schema(joi.string().description(`The absolute path to the directory containing the ConfigTemplate being rendered.`)) | ||
| public path: string |
There was a problem hiding this comment.
Wouldn't this cause an issue where the version calculation is different depending on the directory where the git repository has been checked out in?
Also, most of the time we do not accept absolute paths in the action specs.
Maybe we need to calculate the relative path to the ConfigTemplate from the location of the RenderConfigTemplate.
See also https://discord.com/channels/817392104711651328/1318995192501764151/1319639199036735500
There was a problem hiding this comment.
Ah yeah, that's a good point. Relative paths would avoid the versioning problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added a new template variable for
RenderTemplateconfigs:${template.path}. This is the absolute path to the config template being rendered. This is useful when you want to use the full path to a file or directory next to theConfigTemplatethat's being rendered (e.g. to use a shared Dockerfile that belongs the template, every time you render that template).Which issue(s) this PR fixes:
Addresses a limitation raised by a user on Discord: https://discord.com/channels/817392104711651328/1318995192501764151