This repository has been archived by the owner on Apr 25, 2018. It is now read-only.
c.destroy broken test against master #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great thanks! |
|
Trying to fix something else and I'll move on to this next. |
| import 'rxjs/add/observable/interval' | ||
| import 'rxjs/add/operator/map' | ||
| import 'rxjs/add/operator/merge' | ||
| import 'rxjs/add/observable/of' |
There was a problem hiding this comment.
Do these two lines add anything?
There was a problem hiding this comment.
They use to, but the code that used it was moved to the regression test file. It might be useful to keep them as they are such a common tool to use with Rx anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to "How about a PR with a failing test?" #101
#101 has the fix and this test