Fix shared library build on macOS#5736
Closed
mkoeppe wants to merge 1 commit intogap-system:masterfrom
Closed
Conversation
…ctivate '-install_name'
mkoeppe
added a commit
to mkoeppe/sage
that referenced
this pull request
Jun 8, 2024
Member
|
Thanks for the contribution @mkoeppe, I agree this goes in the right direction. Unfortunately this can't be merged as-is, as it breaks |
mkoeppe
added a commit
to mkoeppe/sage
that referenced
this pull request
Jun 17, 2024
orlitzky
pushed a commit
to orlitzky/sage
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Michael Orlitzky <michael@orlitzky.com>
orlitzky
pushed a commit
to orlitzky/sage
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Michael Orlitzky <michael@orlitzky.com>
orlitzky
pushed a commit
to orlitzky/sage
that referenced
this pull request
Oct 12, 2024
orlitzky
pushed a commit
to orlitzky/sage
that referenced
this pull request
Oct 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS needs
-install_namein the linker command for the dylib.Text for release notes
see title
Further details
see sagemath/sage#38169