fix: Inherit labels and annotations from experiment

Signed-off-by: Ce Gao <[email protected]>
gaocegege · Jan 6, 2020 · f5a7c9f · f5a7c9f
1 parent c8cb2cb
commit f5a7c9f
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 11 deletions.
diff --git a/pkg/controller.v1alpha3/consts/const.go b/pkg/controller.v1alpha3/consts/const.go
@@ -18,6 +18,8 @@ const (
 	LabelExperimentName = "experiment"
 	// LabelSuggestionName is the label of suggestion name.
 	LabelSuggestionName = "suggestion"
+	// LabelDeploymentName is the label of deployment name.
+	LabelDeploymentName = "deployment"
 
 	// ContainerSuggestion is the container name in Suggestion.
 	ContainerSuggestion = "suggestion"

diff --git a/pkg/controller.v1alpha3/experiment/suggestion/suggestion.go b/pkg/controller.v1alpha3/experiment/suggestion/suggestion.go
@@ -57,8 +57,10 @@ func (g *General) createSuggestion(instance *experimentsv1alpha3.Experiment, sug
 	logger := log.WithValues("experiment", types.NamespacedName{Name: instance.Name, Namespace: instance.Namespace})
 	suggestion := &suggestionsv1alpha3.Suggestion{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      instance.Name,
-			Namespace: instance.Namespace,
+			Name:        instance.Name,
+			Namespace:   instance.Namespace,
+			Labels:      instance.Labels,
+			Annotations: instance.Annotations,
 		},
 		Spec: suggestionsv1alpha3.SuggestionSpec{
 			AlgorithmName: instance.Spec.Algorithm.AlgorithmName,

diff --git a/pkg/controller.v1alpha3/suggestion/composer/composer.go b/pkg/controller.v1alpha3/suggestion/composer/composer.go
@@ -54,16 +54,19 @@ func (g *General) DesiredDeployment(s *suggestionsv1alpha3.Suggestion) (*appsv1.
 	}
 	d := &appsv1.Deployment{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      util.GetAlgorithmDeploymentName(s),
-			Namespace: s.Namespace,
+			Name:        util.GetAlgorithmDeploymentName(s),
+			Namespace:   s.Namespace,
+			Labels:      s.Labels,
+			Annotations: s.Annotations,
 		},
 		Spec: appsv1.DeploymentSpec{
 			Selector: &metav1.LabelSelector{
 				MatchLabels: util.SuggestionLabels(s),
 			},
 			Template: corev1.PodTemplateSpec{
 				ObjectMeta: metav1.ObjectMeta{
-					Labels: util.SuggestionLabels(s),
+					Labels:      util.SuggestionLabels(s),
+					Annotations: s.Annotations,
 				},
 				Spec: corev1.PodSpec{
 					Containers: []corev1.Container{

diff --git a/pkg/controller.v1alpha3/util/labels.go b/pkg/controller.v1alpha3/util/labels.go
@@ -6,16 +6,26 @@ import (
 	"github.com/kubeflow/katib/pkg/controller.v1alpha3/consts"
 )
 
+// SuggestionLabels returns the expected suggestion labels.
 func SuggestionLabels(instance *suggestionsv1alpha3.Suggestion) map[string]string {
-	return map[string]string{
-		"deployment":               GetAlgorithmDeploymentName(instance),
-		consts.LabelExperimentName: instance.Name,
-		consts.LabelSuggestionName: instance.Name,
+	res := make(map[string]string)
+	for k, v := range instance.Labels {
+		res[k] = v
 	}
+	res[consts.LabelDeploymentName] = GetAlgorithmDeploymentName(instance)
+	res[consts.LabelExperimentName] = instance.Name
+	res[consts.LabelSuggestionName] = instance.Name
+
+	return res
 }
 
+// TrialLabels returns the expected trial labels.
 func TrialLabels(instance *experimentsv1alpha3.Experiment) map[string]string {
-	return map[string]string{
-		consts.LabelExperimentName: instance.Name,
+	res := make(map[string]string)
+	for k, v := range instance.Labels {
+		res[k] = v
 	}
+	res[consts.LabelExperimentName] = instance.Name
+
+	return res
 }