fix: nadeo failing queries on map info #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosminPerRam
changed the title
|
Thanks @Hornochs for testing this PR and helping with docs. |
Co-authored-by: Stephan Schaffner <[email protected]>
CosminPerRam
force-pushed
the
fix/nadeo
branch
from
945b84f to
a376b98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #634
Servers of Trackmania Nations Forever seem to not respond onGetCurrentMapInfoandGetNextMapInfoanymore, and I couldn't find a suitable replacement, so this fix removes the assignment of themapvalue (and some next map info in the raw object), made a docs note about this.@Hornochs found a method which contains the map name, merged into this branch by #669
The
versionfield is now assigned and the raw object contains more fields that werent added beforehand.Will merge when I'll also get to test the other games that use the protocol:
ShootmaniaandTrackmania 2.