feat: remove cheerio dependency #627
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ping: $(tr).find('td').eq(3).text().trim(), | ||
| team: $(tr).find('td').eq(4).text().toLowerCase(), | ||
| score: parseInt($(tr).find('td').eq(5).text()) | ||
| name: cols[2].replace(/<.*?>/g, '').trim(), |
Check failure
Code scanning / CodeQL
Incomplete multi-character sanitization High
| team: $(tr).find('td').eq(4).text().toLowerCase(), | ||
| score: parseInt($(tr).find('td').eq(5).text()) | ||
| name: cols[2].replace(/<.*?>/g, '').trim(), | ||
| ping: cols[3].replace(/<.*?>/g, '').trim(), |
Check failure
Code scanning / CodeQL
Incomplete multi-character sanitization High
| score: parseInt($(tr).find('td').eq(5).text()) | ||
| name: cols[2].replace(/<.*?>/g, '').trim(), | ||
| ping: cols[3].replace(/<.*?>/g, '').trim(), | ||
| team: cols[4].replace(/<.*?>/g, '').toLowerCase().trim(), |
Check failure
Code scanning / CodeQL
Incomplete multi-character sanitization High
| name: cols[2].replace(/<.*?>/g, '').trim(), | ||
| ping: cols[3].replace(/<.*?>/g, '').trim(), | ||
| team: cols[4].replace(/<.*?>/g, '').toLowerCase().trim(), | ||
| score: parseInt(cols[5].replace(/<.*?>/g, '').trim()) |
Check failure
Code scanning / CodeQL
Incomplete multi-character sanitization High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cheeriowas added forBuild And Shootand was later used forFarming Simulator.In the past,
Build And Shoothad a request and regex implementation, and we are switching back to it (modified version, not original).Farming Simulatorseems to be a bit troublesome to be dealt with, remains to be seen.According to this Bundlephobia scan of the package.json:
Shows that (without
gotat least),cheeriois almost half of the package size.This wouldn't really be a trouble for modules, but it is for commonjs as its pulling the entire package.