-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pallet-flow #8
Conversation
@vovacha we could also collect those primitives which are gamedao specific in another primitives module in here. |
pub type AccountId = u32; | ||
pub type BlockNumber = u32; | ||
pub type Hash = H256; | ||
pub type Timestamp = u64; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub type Timestamp = u64; | |
use zero_primitives::{BlockNumber, Hash, Timestamp}; |
And use those variables here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to explicitly declare those types here to show that they could potentially differ from the actual runtime types from zero_primitives
even if they are the same now.
|
||
/// Campaign | ||
#[pallet::storage] | ||
#[pallet::getter(fn campaign_by_id)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a ToDo somewhere in the file to update storage objects and drop getters as we discussed earlier?
|
||
// unreserve the amount in contributor balance | ||
T::Currency::unreserve( | ||
T::FundingCurrencyId::get(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can store result of T::FundingCurrencyId::get()
to some variable and use it instead, since this value is used in multiple places over the on_finalize
hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Both getters refactoring, and this issue will be handled later during the hardening stage.
Pallet Flow migration.
DONE:
orml-currencies
support.TODO:
Next steps: