Pallet updates according to latest discussions #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vayesy
commented
Mar 25, 2022
vayesy
commented
- Additional validations when creating withdrawal proposal.
- Added missing docstrings.
- Updated tests.
vovacha
reviewed
Mar 25, 2022
control/src/lib.rs
Outdated
| @@ -641,7 +657,7 @@ impl<T: Config> Pallet<T> { | |||
| } | |||
| } | |||
|
|
|||
| fn remove(org_id: T::Hash, account: T::AccountId) -> DispatchResult { | |||
| fn remove_org_member(org_id: T::Hash, account: T::AccountId) -> DispatchResult { | |||
There was a problem hiding this comment.
Let's finish our long discussion about function names right here.
I'd stick to "do_{extrinsic_name}" format.
Example FRAME Uniques: https://github.com/paritytech/substrate/blob/master/frame/uniques/src/functions.rs#L25
Or, please, suggest other options.
There was a problem hiding this comment.
Let's use do_... naming.
…ng docstrings. Updated tests.
vayesy
force-pushed
the
migration/pallets-refactoring
branch
from
32647d4 to
dba2d0d
Compare
|
👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.