Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pallet-sense #1

Merged
merged 7 commits into from
Feb 11, 2022
Merged

Add pallet-sense #1

merged 7 commits into from
Feb 11, 2022

Conversation

vovacha
Copy link
Contributor

@vovacha vovacha commented Feb 11, 2022

sense-pallet migration.

What was done?

  • Change the syntax to the newest Substrate version with minor changes.
  • Add tests and mocks.
  • Add benchmarks.

Tests:

❯ cargo test -p pallet-sense --all-features
   Compiling pallet-sense v0.1.0 (/Users/vovacha/Projects/gamedao/gamedao-acala/gamedao/sense)
    Finished test [unoptimized + debuginfo] target(s) in 2.71s
     Running unittests (target/debug/deps/pallet_sense-952d6876c90a0174)

running 6 tests
test mock::__construct_runtime_integrity_test::runtime_integrity_tests ... ok
test tests::sense_mod_rep ... ok
test tests::sense_mod_trust ... ok
test tests::sense_mod_xp ... ok
test tests::sense_create_entity ... ok
test benchmarking::benchmark_tests::test_benchmarks ... ok

test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests pallet-sense

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

Volodymyr Brazhnyk added 2 commits February 11, 2022 19:15
@vovacha vovacha requested review from 2075, vayesy and cryply February 11, 2022 17:28
@vovacha vovacha self-assigned this Feb 11, 2022
sense/src/lib.rs Outdated Show resolved Hide resolved
sense/src/lib.rs Outdated Show resolved Hide resolved
sense/src/mock.rs Show resolved Hide resolved
sense/src/tests.rs Show resolved Hide resolved
sense/src/tests.rs Show resolved Hide resolved
@vayesy vayesy self-requested a review February 11, 2022 18:33
@2075
Copy link
Member

2075 commented Feb 11, 2022

nice review, thanks @vovacha @BigKon

@2075
Copy link
Member

2075 commented Feb 11, 2022

we can also merge with two reviewers, if you like, @cryply can review still.

@2075 2075 merged commit fd43b87 into main Feb 11, 2022
@vayesy vayesy deleted the feature/sense-pallet branch February 17, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants