This repository has been archived by the owner on Mar 31, 2024. It is now read-only.
Avoid references to rd.Port and rd.Host until after they are initialized. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah yeah I understand that. 👍 from me for now (I agree combining the two functions would be optimal but this is good enough). |
|
FYI @gamalan when you find a few minutes, this is 👍 for me (it's a followup on a recent PR of mine) |
gamalan
approved these changes
Nov 6, 2023
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a bandaid fix, the real solution would be to merge GetConfigValue and ReplaceEnvConfigCaddy into one function and sort the references to the variables according to the order how they are referenced.