-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI fails #560
Fix CI fails #560
Conversation
ca97667
to
45ca625
Compare
db55bff
to
8cdbe7a
Compare
01fdf11
to
456ed65
Compare
6efa669
to
6fe671b
Compare
a46d368
to
6c1614d
Compare
980e44f
to
7fce367
Compare
b897502
to
632d9fc
Compare
@nsoranzo note that I increased the allowed cyclomatic complexity (for lintr) to 25 which seems to the the documented default .. still, 1 is failing: any ideas .. I just don't want to touch the code more than necessary |
What about |
434ae08
to
120c5ed
Compare
This is an option. But, actually I found it a useful indicator of bad code. Maybe its acceptable to simply ignore such errors if submitter has done everything to improve the code... |
I agree it's a useful indicator, but maybe it's a bit too invasive compared to space and indentation style changes. No strong opinion any way. |
cummerbund: fix requirements - 2.16.0 was not installable anymore (conda took forever) 2.20 was the closest that worked. I added r-base to speed up conda. - added fonts for pngs that actually contain text - removed unneeded r-png requirement - switch from test data to asserts cufflinks: - moved to IUC galaxyproject/tools-iuc#3069 dwt*: - remove perl wrappers and use Rscripts directly Co-authored-by: Nicola Soranzo <[email protected]>
120c5ed
to
4e17a8d
Compare
Ready from my side. |
Co-authored-by: Nicola Soranzo <[email protected]>
Co-authored-by: Nicola Soranzo <[email protected]>
Thanks @bernt-matthias , fantastic work! |
Try to fix tools failing in the first run of the CI workflow: https://github.com/galaxyproject/tools-devteam/actions/runs/120951902
Other changes to testing framework:
--no_dependency_resolution
toplanemo test
setup.cfg
.tt_skip
TODO: