Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROCEDURES] Describe tags used to construct release notes. #871

Closed
wants to merge 1 commit into from

Conversation

jmchilton
Copy link
Member

No description provided.

@jmchilton
Copy link
Member Author

Promised rework of #663, see discussion on #868.

@jmchilton
Copy link
Member Author

My preference at this point would be to document tags somewhere else in the codebase and just update the PROCEDURES to state that the merger of the pull request is responsible for ensuring the tags are in compliance with that document. This way we can have a sane, non-PROCEDURES discussion of tag policy.

@hexylena
Copy link
Member

hexylena commented Oct 8, 2015

In the discussion mentioned above, I'm in favour of this, and of documenting meanings/usages elsewhere and just merger must tag.

I'd go further to say that maybe it would be sensible to not limit ourselves to those three tags, and just say "the person merging the PR must ensure the PR has appropriate tags, please see X for our tag hierarchy/meanings/requirements", but I was not part of other discussions regarding tag taxonomy so perhaps those three really encompass the entirety of what we need to communicate with issue tagging.

@nsoranzo
Copy link
Member

nsoranzo commented Oct 8, 2015

My preference at this point would be to document tags somewhere else in the codebase and just update the PROCEDURES to state that the merger of the pull request is responsible for ensuring the tags are in compliance with that document.

@jmchilton I agree, than probably it's faster to close this PR and open a new one with this splitted in the new doc?

@dannon
Copy link
Member

dannon commented Oct 8, 2015

@jmchilton Like I mentioned on the other thread in question, we've had some working-group style discussion on this and I'll be opening a new issue once I've written up the proposal. I'm not sure it's worth updating this right now (especially with the release notes already in-process for 15.10), and would favor just looking at and iterating on the proposal once I get it formalized and posted.

@jmchilton
Copy link
Member Author

Closed in lieu #902 and anticipated follow up actions.

@hexylena hexylena closed this Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants