Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce tool form building frequency #18969

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Reduce tool form building frequency #18969

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed0e0d2
Reduce buildFormData calls
davelopez Oct 8, 2024
2b5d16a
Debounce onChange calls to avoid unnecessary tool rebuilding
davelopez Oct 10, 2024
62939c6
Revert "Debounce onChange calls to avoid unnecessary tool rebuilding"
davelopez Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions client/src/components/Form/FormDisplay.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,7 @@ export default {
},
created() {
this.onCloneInputs();
// build flat formData that is ready to be submitted
this.formData = this.buildFormData();
// emit back to parent, so that parent has submittable data
this.$emit("onChange", this.formData);
this.onChange();
// highlight initial warnings
this.onWarnings();
// highlight initial errors
Expand Down
Loading