-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Add custom XCM Weight Trader #48
Conversation
Co-authored-by: Martin Hloska <[email protected]>
enthusiastmartin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok me.
you can actually merge the latest master - it will simplify as some of the changes were done as part of another Pr
enthusiastmartin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still some issue in the build ( clippy is complaining i believe)
lgtm when fixed and build passes
I'm unsure how to fix the clippy error as it doesn't seem to be in our repo but in Polkadot? |
Fixed it for you for now. it is due to the runtime-benchmarks features used in the repo. and we run clippy with all-features. |
Codecov Report
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 76.70% 76.31% -0.40%
==========================================
Files 16 17 +1
Lines 983 1047 +64
==========================================
+ Hits 754 799 +45
- Misses 229 248 +19
Continue to review full report at Codecov.
|
This PR adds:
hydradx-adapterscrate to the warehouse that (for now) contains:MultiCurrencyTraderToFeeReceiverthat implementsTakeRevenueand channels it to pallet transaction multi payment's fee receiverNativePriceOracletrait inhydradx-traitsand an implementation in pallet multi-transaction-paymentbased on #42
Todo:
WeightToFeemove fromtrait PriceOracleto a customWeightToFeetrait that can be parameterized on currencies.