Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

Conversation

@apopiak
Copy link
Contributor

@apopiak apopiak commented May 13, 2022

This PR adds:

  • a hydradx-adapters crate to the warehouse that (for now) contains:
    • the custom XCM weight trader MultiCurrencyTrader
    • the struct ToFeeReceiver that implements TakeRevenue and channels it to pallet transaction multi payment's fee receiver
  • a NativePriceOracle trait in hydradx-traits and an implementation in pallet multi-transaction-payment

based on #42

Todo:

  • discarded the idea of a custom WeightToFee
    move from trait PriceOracle to a custom WeightToFee trait that can be parameterized on currencies.

@apopiak apopiak marked this pull request as ready for review May 25, 2022 23:26
@apopiak apopiak requested a review from enthusiastmartin June 13, 2022 13:56
Copy link
Member

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok me.

you can actually merge the latest master - it will simplify as some of the changes were done as part of another Pr

Copy link
Member

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still some issue in the build ( clippy is complaining i believe)

lgtm when fixed and build passes

@apopiak
Copy link
Contributor Author

apopiak commented Jun 14, 2022

There is still some issue in the build ( clippy is complaining i believe)

lgtm when fixed and build passes

I'm unsure how to fix the clippy error as it doesn't seem to be in our repo but in Polkadot?

@enthusiastmartin
Copy link
Member

There is still some issue in the build ( clippy is complaining i believe)
lgtm when fixed and build passes

I'm unsure how to fix the clippy error as it doesn't seem to be in our repo but in Polkadot?

Fixed it for you for now.

it is due to the runtime-benchmarks features used in the repo.

and we run clippy with all-features.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #48 (d8b214d) into main (4276029) will decrease coverage by 0.39%.
The diff coverage is 70.31%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   76.70%   76.31%   -0.40%     
==========================================
  Files          16       17       +1     
  Lines         983     1047      +64     
==========================================
+ Hits          754      799      +45     
- Misses        229      248      +19     
Impacted Files Coverage Δ
transaction-multi-payment/src/lib.rs 66.83% <0.00%> (-0.69%) ⬇️
adapters/src/lib.rs 72.58% <72.58%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4276029...d8b214d. Read the comment docs.

@apopiak apopiak merged commit 7052eea into main Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants