Skip to content

feat: ensure liquidity mining NFT id is within reserved range #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrq1911 merged 7 commits into from
May 10, 2022
Merged

feat: ensure liquidity mining NFT id is within reserved range #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f18a49
add integrity test to verify that ClassId has correct value
Roznovjak May 5, 2022
07fca24
add comment to config
Roznovjak May 5, 2022
31ab664
update pallet version
Roznovjak May 6, 2022
1af6cae
Merge branch 'master' into liq_mining/test_class_id
Roznovjak May 6, 2022
40a3728
Merge branch 'master' into liq_mining/test_class_id
mrq1911 May 9, 2022
c4fcdfa
Merge branch 'master' into liq_mining/test_class_id
Roznovjak May 10, 2022
0070608
Merge branch 'master' into liq_mining/test_class_id
mrq1911 May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pallets/liquidity-mining/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "pallet-liquidity-mining"
version = "1.0.1"
version = "1.1.0"
description = "Liquidity mining"
authors = ["GalacticCouncil"]
edition = "2018"
Expand Down
9 changes: 8 additions & 1 deletion pallets/liquidity-mining/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,13 @@ pub mod pallet {
fn on_runtime_upgrade() -> frame_support::weights::Weight {
migration::init_nft_class::<T>()
}

fn integrity_test() {
assert!(
T::NftClass::get() <= T::ReserveClassIdUpTo::get(),
"`NftClass` must be within the range of reserved NFT class IDs"
);
}
}

#[pallet::config]
Expand Down Expand Up @@ -280,7 +287,7 @@ pub mod pallet {
/// The block number provider
type BlockNumberProvider: BlockNumberProvider<BlockNumber = Self::BlockNumber>;

/// NFT class id for liq. mining deposit nfts.
/// NFT class id for liq. mining deposit nfts. Has to be within the range of reserved NFT class IDs.
type NftClass: Get<primitives::ClassId>;

/// Weight information for extrinsic in this module.
Expand Down