This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(solc): flatten import loc #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
suggested changes
Feb 22, 2022
gakonst
approved these changes
Feb 22, 2022
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Feb 22, 2022
parse fantom gakonst/ethers-rs#941 fix flattening gakonst/ethers-rs#946 consistent bytecode prefixing gakonst/ethers-rs#948
charisma98
added a commit
to charisma98/foundry
that referenced
this pull request
Mar 4, 2023
parse fantom gakonst/ethers-rs#941 fix flattening gakonst/ethers-rs#946 consistent bytecode prefixing gakonst/ethers-rs#948
0129general
added a commit
to 0129general/FoundryProject
that referenced
this pull request
May 8, 2024
parse fantom gakonst/ethers-rs#941 fix flattening gakonst/ethers-rs#946 consistent bytecode prefixing gakonst/ethers-rs#948
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The import location detection on solang failure change introduced in this commit erroneously identified the import location within the file contents.
i.e.
import "./Contract.sol";would capture only./Contract.solinstead of the full import statement together withimportkeyword and trailing semicolon.Solution
Revert the change & add the test case that forces solang failure and ensures the correct flattening of the target file.
PR Checklist