Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

feature: set nonce in fill transaction #687

Merged
merged 4 commits into from
Dec 13, 2021
Merged

Conversation

prestwich
Copy link
Collaborator

@prestwich prestwich commented Dec 13, 2021

Motivation

Set nonces properly when filling transactions. Previously, nonces have been set by the node or the nonce manager during send_transaction calls. I erroneously assumed that fill_transaction would set the nonce. As a result, send_escalating never properly sets the nonce. This PR adds two additional places a nonce may be filled

Previously, I wanted to add a nonce filler to fill_transaction however, this would always override the node's suggested nonce when using an RPC signer via send_transaction. Instead, I chose to add it to send_escalating

Solution

  • add a nonce check to send_escalating
  • ensure NonceManagerMiddleware fills the nonce from its manager

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@prestwich prestwich added the bug Something isn't working label Dec 13, 2021
@prestwich prestwich requested a review from gakonst December 13, 2021 21:05
@gakonst gakonst merged commit 3338cde into master Dec 13, 2021
@gakonst gakonst deleted the prestwich/fill-nonce branch December 13, 2021 22:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants