This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Set nonces properly when filling transactions. Previously, nonces have been set by the node or the nonce manager during
send_transaction
calls. I erroneously assumed thatfill_transaction
would set the nonce. As a result,send_escalating
never properly sets the nonce. This PR adds two additional places a nonce may be filledPreviously, I wanted to add a nonce filler to
fill_transaction
however, this would always override the node's suggested nonce when using an RPC signer viasend_transaction
. Instead, I chose to add it tosend_escalating
Solution
send_escalating
NonceManagerMiddleware
fills the nonce from its managerPR Checklist