This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(solc): remove changed artifacts from the cache #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate artifacts will be returned if there is a changed artifact that was already present in the cache
ghost
changed the title
ghost
deleted the
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Nov 28, 2021
1. Introduces ethers-solc tracing
2. Fixes various ethers-solc caching bugs
gakonst/ethers-rs#623
gakonst/ethers-rs#629
gakonst/ethers-rs#630
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Nov 28, 2021
1. Introduces ethers-solc tracing
2. Fixes various ethers-solc caching bugs
gakonst/ethers-rs#623
gakonst/ethers-rs#629
gakonst/ethers-rs#630
charisma98
added a commit
to charisma98/foundry
that referenced
this pull request
Mar 4, 2023
1. Introduces ethers-solc tracing
2. Fixes various ethers-solc caching bugs
gakonst/ethers-rs#623
gakonst/ethers-rs#629
gakonst/ethers-rs#630
0129general
added a commit
to 0129general/FoundryProject
that referenced
this pull request
May 8, 2024
1. Introduces ethers-solc tracing
2. Fixes various ethers-solc caching bugs
gakonst/ethers-rs#623
gakonst/ethers-rs#629
gakonst/ethers-rs#630
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When reading from the cache, there may be changed artifacts that need to be recompiled.
Currently only missing files are removed from the cache metadata struct, but changed files remain.
Since we're now returning the cached artifacts as part of #623 on partial changes and writing new
files to the cache as part of #629, we also need to remove changed files from the cache.
Solution
After getting the changed sources, remove them from the cache metadata (
SolFilesCache) sothey are no longer returned.
PR Checklist