This repository was archived by the owner on Oct 19, 2024. It is now read-only.
fix: change the type of block number and pub key #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanyunx
force-pushed
the
hanyunx/celo_providers
branch
from
78d234f to
972012c
Compare
hanyunx
force-pushed
the
hanyunx/celo_providers
branch
from
972012c to
23ff878
Compare
|
The clippy failed in files that were not touched, any idea why this happened? @gakonst Also the clippy passed locally. |
|
Clippy error is unrelated. Will fix. |
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up on #314, changed the type of block number to the generic
Into<BlockId>so that the client can query with the input of typeu64other than convertingu64toBlockIdmanually.Changed the type of returned public key to
Stringsince the client cannot deserialize the response data otherwise.