Skip to content
This repository was archived by the owner on Oct 19, 2024. It is now read-only.

fix: change the type of block number and pub key #320

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

hanyunx
Copy link
Contributor

@hanyunx hanyunx commented Jun 17, 2021

A follow up on #314, changed the type of block number to the generic Into<BlockId> so that the client can query with the input of type u64 other than converting u64 to BlockId manually.

Changed the type of returned public key to String since the client cannot deserialize the response data otherwise.

@hanyunx hanyunx force-pushed the hanyunx/celo_providers branch from 78d234f to 972012c Compare June 17, 2021 22:02
@hanyunx hanyunx force-pushed the hanyunx/celo_providers branch from 972012c to 23ff878 Compare June 17, 2021 22:06
@hanyunx
Copy link
Contributor Author

hanyunx commented Jun 17, 2021

The clippy failed in files that were not touched, any idea why this happened? @gakonst

Also the clippy passed locally.

@gakonst gakonst merged commit 2a513f8 into gakonst:master Jun 22, 2021
@gakonst
Copy link
Owner

gakonst commented Jun 22, 2021

Clippy error is unrelated. Will fix.

meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this pull request Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants