Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix: use to_string in mainnet chain variant #2275

Merged
merged 2 commits into from
Mar 17, 2023
Merged

fix: use to_string in mainnet chain variant #2275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34d8038
fix: use to_string in mainnet chain variant
CodeSandwich Mar 17, 2023
e68b59a
Add test for chain serde and to_string matching
CodeSandwich Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ethers-core/src/types/chain.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ pub type ParseChainError = TryFromPrimitiveError<Chain>;
#[strum(serialize_all = "kebab-case")]
#[repr(u64)]
pub enum Chain {
#[strum(serialize = "ethlive", serialize = "mainnet")]
#[strum(to_string = "mainnet", serialize = "ethlive")]
#[serde(alias = "ethlive")]
Mainnet = 1,
Morden = 2,
Ropsten = 3,
Expand Down Expand Up @@ -598,6 +599,7 @@ mod tests {

// kebab-case
const ALIASES: &[(Chain, &[&str])] = &[
(Mainnet, &["ethlive"]),
(BinanceSmartChain, &["bsc", "binance-smart-chain"]),
(BinanceSmartChainTestnet, &["bsc-testnet", "binance-smart-chain-testnet"]),
(XDai, &["xdai", "gnosis", "gnosis-chain"]),
Expand All @@ -614,4 +616,13 @@ mod tests {
}
}
}

#[test]
fn serde_to_string_match() {
for chain in Chain::iter() {
let chain_serde = serde_json::to_string(&chain).unwrap();
let chain_string = format!("\"{}\"", chain.to_string());
assert_eq!(chain_serde, chain_string);
}
}
}